Fix minor bugs involving model manager handling of model paths #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Leave models found in the `autoimport` directory there. Do not move them into the `models` hierarchy. - If model name, type or base is updated and model is in the `models` directory, update its path as appropriate. - On startup during model scanning, if a model's path is a symbolic link, then resolve to an absolute path before deciding it is a new model that must be hashed and registered. (This prevents needless hashing at startup time).
lstein
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
api
python
hipsterusername
approved these changes
Mar 21, 2024
psychedelicious
requested changes
Mar 21, 2024
psychedelicious
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects a number of minor bugs in model path handling found while testing rc4.
autoimportdirectory there. Do not move them into themodelshierarchy.modelsdirectory, update its path as appropriate.Related Issues / Discussions
QA Instructions
The model installer unit tests have been updated to check these conditions.
Merge Plan
Merge when approved.
Checklist